From 912f4e3e21b5150dfd6cdf979baaa0acdff96b61 Mon Sep 17 00:00:00 2001 From: Jeroen De Meerleer Date: Thu, 30 May 2019 08:33:16 +0200 Subject: [PATCH] Some documentation and bugfixes --- src/Models/Player.php | 4 ++-- src/Readers/Pairtwo6.php | 2 -- src/Tournament.php | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/Models/Player.php b/src/Models/Player.php index 216b56b..18e8ebd 100644 --- a/src/Models/Player.php +++ b/src/Models/Player.php @@ -70,7 +70,7 @@ abstract class Player /** * @return string[] */ - public function getIds(): array + public function getIds(): ?array { return $this->Ids; } @@ -88,7 +88,7 @@ abstract class Player /** * @return int[] */ - public function getElos(): array + public function getElos(): ?array { return $this->Elos; } diff --git a/src/Readers/Pairtwo6.php b/src/Readers/Pairtwo6.php index 4f3b88d..208e017 100644 --- a/src/Readers/Pairtwo6.php +++ b/src/Readers/Pairtwo6.php @@ -458,8 +458,6 @@ class Pairtwo6 extends Pairtwo6Model implements ReaderInterface $player->setBinaryData("TieMatch", $this->readData('Int', substr($swscontents, $offset, $length))); $offset += $length; - $player->setElos($elos); - $player->setIds($ids); $this->getTournament()->addPlayer($player); } // PlayerNames diff --git a/src/Tournament.php b/src/Tournament.php index 333c36a..cd08fa7 100644 --- a/src/Tournament.php +++ b/src/Tournament.php @@ -264,7 +264,7 @@ class Tournament extends Tiebreaks /** - * @return float|bool + * @return float|null */ private function calculateTiebreak(Tiebreak $tiebreak, Player $player, int $tbkey = 0): ?float {