From f34bfedb7d5670cd3abde945bf1e17e5f179b144 Mon Sep 17 00:00:00 2001 From: Jeroen De Meerleer Date: Wed, 29 May 2019 18:20:45 +0200 Subject: [PATCH] Updated Converting your code to the generalized format (markdown) --- ...ing-your-code-to-the-generalized-format.md | 23 ++++++++++--------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/Converting-your-code-to-the-generalized-format.md b/Converting-your-code-to-the-generalized-format.md index 23e454f..25e4ae0 100644 --- a/Converting-your-code-to-the-generalized-format.md +++ b/Converting-your-code-to-the-generalized-format.md @@ -32,12 +32,12 @@ Currently not all and enough tiebreaks are implemented. Therefore this change is | Property | Old code | New Code (getter) | Current Status | |------------------------------|-------------------------------------------------|------------------------------------------|----------------| | Player::Absent | `Player::getAbsent()` | `Player::getBinaryData('Absent')` | Consideration | -| Player::Club | `Player::getClub()` | `Player::getIds()['Club']` | Temporary | +| Player::Club | `Player::getClub()` | `Player::getId('club')` | Final | | Player::ExtraPts | `Player::getExtraPts()` | `Player::getBinaryData('XtraPts')` | Final | -| Player::FideElo | `Player::getFideElo()` | `Player::getElos()['fide']` | Temporary | -| Player::FideId | `Player::getFideId()` | `Player::getIds()['fide']` | Temporary | -| Player::KbsbElo | `Player::getKbsbElo()` | `Player::getElos()['kbsb']` | Temporary | -| Player::KbsbId | `Player::getKbsbId()` | `Player::getIds()['kbsb']` | Temporary | +| Player::FideElo | `Player::getFideElo()` | `Player::getElo('world')` | Final | +| Player::FideId | `Player::getFideId()` | `Player::getId('world')` | Final | +| Player::KbsbElo | `Player::getKbsbElo()` | `Player::getElo('home')` | Final | +| Player::KbsbId | `Player::getKbsbId()` | `Player::getId('home')` | Final | | Player::NumberOfTies | `Player::getNumberofTies()` | `Player::getBinaryData('NumberOfTies')` | Final | | Player::Points | `Player::getPoints()` | `Player::getBinaryData('Points')` | Final | | Player::Rank | `Player::getRank()` | `Player::getBinaryData('Rank')` | Final | @@ -59,12 +59,12 @@ Currently not all and enough tiebreaks are implemented. Therefore this change is | Property | Old code | New Code (setter) | Current Status | |------------------------------|-----------------------------------------------------------------|--------------------------------------------------|----------------| | Player::Absent | `Player::setAbsent($value)` | `Player::setBinaryData('Absent', $value)` | Consideration | -| Player::Club | `Player::setClub($value)` | `(not implemented, yet)` | Temporary | +| Player::Club | `Player::setClub($value)` | `Player::setId('club', $value)` | Final | | Player::ExtraPts | `Player::setExtraPts($value)` | `Player::setBinaryData('XtraPts', $value)` | Final | -| Player::FideElo | `Player::setFideElo($value)` | `(not implemented, yet)` | Temporary | -| Player::FideId | `Player::setFideId($value)` | `(not implemented, yet)` | Temporary | -| Player::KbsbElo | `Player::setKbsbElo($value)` | `(not implemented, yet)` | Temporary | -| Player::KbsbId | `Player::setKbsbId($value)` | `(not implemented, yet)` | Temporary | +| Player::FideElo | `Player::setFideElo($value)` | `Player::setElo('world', $value)` | Final | +| Player::FideId | `Player::setFideId($value)` | `Player::setId('world', $value)`` | Final | +| Player::KbsbElo | `Player::setKbsbElo($value)` | `Player::setElo('home', $value)` | Final | +| Player::KbsbId | `Player::setKbsbId($value)` | `Player::setId('home', $value)` | Final | | Player::NumberOfTies | `Player::setNumberofTies($value)` | `Player::setBinaryData('NumberOfTies', $value)` | Final | | Player::Points | `Player::setPoints($value)` | `Player::setBinaryData('Points', $value)` | Final | | Player::Rank | `Player::setRank($value)` | `Player::setBinaryData('Rank', $value)` | Final | @@ -79,4 +79,5 @@ Currently not all and enough tiebreaks are implemented. Therefore this change is | Sws::Players($i)_Paired | `Sws::setBinaryData('Players($i, $value)_Paired', $value)` | `Player::setBinaryData('Paired', $value)` | Final | | Sws::Players($i)_NameLength | `Sws::setBinaryData('Players($i, $value)_NameLength', $value)` | `Player::setBinaryData('NameLength', $value)` | Final | | Sws::Players($i)_Namepos | `Sws::setBinaryData('Players($i, $value)_Namepos', $value)` | `Player::setBinaryData('NamePos', $value)` | Final | -| Sws::Players($i)_TieMatch | `Sws::setBinaryData('Players($i, $value)_TieMatch', $value)` | `Player::setBinaryData('Tiematch', $value)` | Final | \ No newline at end of file +| Sws::Players($i)_TieMatch | `Sws::setBinaryData('Players($i, $value)_TieMatch', $value)` | `Player::setBinaryData('Tiematch', $value)` | Final | +