From 75aa16c27795e693c4c0e5f127044a4565814b72 Mon Sep 17 00:00:00 2001 From: "Shao Yu-Lung (Allen)" Date: Fri, 16 Dec 2022 21:36:33 +0800 Subject: [PATCH 1/2] update nvm version --- workspace/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workspace/Dockerfile b/workspace/Dockerfile index 63e99fc3..4f277ebb 100644 --- a/workspace/Dockerfile +++ b/workspace/Dockerfile @@ -736,7 +736,7 @@ ENV NVM_NODEJS_ORG_MIRROR ${NVM_NODEJS_ORG_MIRROR} RUN if [ ${INSTALL_NODE} = true ]; then \ # Install nvm (A Node Version Manager) mkdir -p $NVM_DIR && \ - curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.38.0/install.sh | bash \ + curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.2/install.sh | bash \ && . $NVM_DIR/nvm.sh \ && nvm install ${NODE_VERSION} \ && nvm use ${NODE_VERSION} \ From 566eaa64ba6176d53f367e432faf5284dd9e3239 Mon Sep 17 00:00:00 2001 From: "Shao Yu-Lung (Allen)" Date: Fri, 16 Dec 2022 21:40:24 +0800 Subject: [PATCH 2/2] nvm will handle npm global bin path --- workspace/Dockerfile | 4 ---- 1 file changed, 4 deletions(-) diff --git a/workspace/Dockerfile b/workspace/Dockerfile index 4f277ebb..a4cb4a7b 100644 --- a/workspace/Dockerfile +++ b/workspace/Dockerfile @@ -760,7 +760,6 @@ RUN if [ ${INSTALL_NODE} = true ]; then \ && if [ ${INSTALL_NPM_ANGULAR_CLI} = true ]; then \ npm install -g @angular/cli \ ;fi \ - && ln -s `npm bin --global` /home/laradock/.node-bin \ ;fi # Wouldn't execute when added to the RUN statement in the above block @@ -780,9 +779,6 @@ RUN if [ ${INSTALL_NODE} = true ]; then \ echo '[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" # This loads nvm' >> ~/.bashrc \ ;fi -# Add PATH for node -ENV PATH $PATH:/home/laradock/.node-bin - # Make it so the node modules can be executed with 'docker-compose exec' # We'll create symbolic links into '/usr/local/bin'. RUN if [ ${INSTALL_NODE} = true ]; then \