From 8fae1c89e1b29380ae9425c2c865025662dce42a Mon Sep 17 00:00:00 2001
From: Jeroen De Meerleer <me@jeroened.be>
Date: Fri, 30 Jul 2021 15:14:04 +0200
Subject: [PATCH] ENHANCEMENT: you cannot trust datetime-local, yet

---
 assets/job/add.js            | 6 ++++--
 templates/job/add.html.twig  | 4 ++--
 templates/job/edit.html.twig | 4 ++--
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/assets/job/add.js b/assets/job/add.js
index ac3d3aa..2a3e43d 100644
--- a/assets/job/add.js
+++ b/assets/job/add.js
@@ -153,8 +153,10 @@ function handleSecretCheckbox(event) {
 
 function initEternalCheckbox() {
     document.querySelector('.lastrun-eternal').addEventListener('click', event => {
-        document.querySelector('#lastrunselector').prop('disabled', document.querySelector(this).prop('checked'));
-        document.querySelector('#lastrunselector').prop('value', '');
+        let nextrunselector = document.querySelector('#lastrunselector');
+        nextrunselector.disabled = event.target.checked;
+        nextrunselector.placeholder = event.target.checked ? '' : nextrunselector.dataset.placeholder;
+        nextrunselector.value = '';
     })
 }
 
diff --git a/templates/job/add.html.twig b/templates/job/add.html.twig
index 891f3d5..2ee342b 100644
--- a/templates/job/add.html.twig
+++ b/templates/job/add.html.twig
@@ -30,7 +30,7 @@
 
     <div class="mb-3">
         <label for="nextrun">Next run</label>
-        <input type="datetime-local" autocomplete="off" id="nextrunselector" class="form-control datetimepicker-input" data-target="#nextrunselector" data-bs-toggle="datetimepicker" name="nextrun">
+        <input type="text" autocomplete="off" pattern="[0-9]{2}\/[0-9]{2}\/[0-9]{4} [0-9]{2}:[0-9]{2}:[0-9]{2}"placeholder="{{ date() | date("d/m/Y H:i:s")}}" step="1" id="nextrunselector" class="form-control datetimepicker-input" data-target="#nextrunselector" data-bs-toggle="datetimepicker" name="nextrun">
     </div>
 
     <div class="mb-3">
@@ -40,7 +40,7 @@
                 <input type="checkbox" name="lastrun-eternal" class="lastrun-eternal" placeholder="value" value="true" {% if attribute(data, 'lastrun-eternal') is not empty %} checked{% endif %}>
             </div>
             <span class="input-group-text border-start-0">Eternal</span>
-            <input type="datetime-local" autocomplete="off" id="lastrunselector" class="form-control datetimepicker-input" data-target="#lastrunselector" data-bs-toggle="datetimepicker" name="lastrun">
+            <input type="text" autocomplete="off" pattern="[0-9]{2}\/[0-9]{2}\/[0-9]{4} [0-9]{2}:[0-9]{2}:[0-9]{2}" placeholder="{{ date() | date("d/m/Y H:i:s")}}" data-placeholder="{{ date() | date("d/m/Y H:i:s")}}" id="lastrunselector" class="form-control datetimepicker-input" data-target="#lastrunselector" data-bs-toggle="datetimepicker" name="lastrun">
         </div>
     </div>
 
diff --git a/templates/job/edit.html.twig b/templates/job/edit.html.twig
index 6105a16..ef6b3ce 100644
--- a/templates/job/edit.html.twig
+++ b/templates/job/edit.html.twig
@@ -27,7 +27,7 @@
     </div>
     <div class="mb-3">
         <label for="nextrun">Next run</label>
-        <input type="text" autocomplete="off" id="nextrunselector" class="form-control datetimepicker-input" data-target="#nextrunselector" data-bs-toggle="datetimepicker" name="nextrun" value="{{ nextrun |  date("d/m/Y H:i:s")}}">
+        <input type="text" autocomplete="off" pattern="[0-9]{2}\/[0-9]{2}\/[0-9]{4} [0-9]{2}:[0-9]{2}:[0-9]{2}" placeholder="{{ date() | date("d/m/Y H:i:s")}}" id="nextrunselector" class="form-control datetimepicker-input" data-target="#nextrunselector" data-bs-toggle="datetimepicker" name="nextrun" value="{{ nextrun | date("d/m/Y H:i:s")}}">
     </div>
     <div class="mb-3">
         <label for="lastrun">Last run</label>
@@ -36,7 +36,7 @@
                 <input type="checkbox" name="lastrun-eternal" class="lastrun-eternal" placeholder="value" value="true"{% if lastrun is empty %} checked{% endif %}>
             </div>
             <span class="input-group-text border-start-0">Eternal</span>
-            <input type="text" autocomplete="off" id="lastrunselector" class="form-control datetimepicker-input" data-target="#lastrunselector" data-bs-toggle="datetimepicker" name="lastrun"{% if lastrun is empty %} disabled{% else %} value="{{ lastrun |  date("d/m/Y H:i:s")}}"{% endif %}>
+            <input type="text" autocomplete="off" pattern="[0-9]{2}\/[0-9]{2}\/[0-9]{4} [0-9]{2}:[0-9]{2}:[0-9]{2}" data-placeholder="{{ date() | date("d/m/Y H:i:s")}}" id="lastrunselector" class="form-control datetimepicker-input" data-target="#lastrunselector" data-bs-toggle="datetimepicker" name="lastrun"{% if lastrun is empty %} disabled{% else %} value="{{ lastrun | date("d/m/Y H:i:s")}}"{% endif %}>
         </div>
     </div>