mirror of
https://github.com/JeroenED/libpairtwo.git
synced 2024-11-21 22:17:41 +01:00
Merge branch 'task/binarydataIsNull' into develop
This commit is contained in:
commit
185f0b86fb
@ -1,6 +1,7 @@
|
||||
# CHANGELOG
|
||||
|
||||
## vx.y.z (Release: aa-bbb-cccc)
|
||||
* ENHANCEMENT: `Class::getBinaryData` methods return null if field is non-existent
|
||||
* BUGFIX: `Player:GetId` returns elo instead of id
|
||||
|
||||
## v1.1.2 (Release: 21-jun-2019)
|
||||
|
@ -464,11 +464,14 @@ class Player
|
||||
* Returns binary data that was read out the pairtwo file but was not needed immediately
|
||||
*
|
||||
* @param string $Key
|
||||
* @return bool|DateTime|int|string
|
||||
* @return bool|DateTime|int|string|null
|
||||
*/
|
||||
public function getBinaryData(string $Key)
|
||||
{
|
||||
return $this->BinaryData[$Key];
|
||||
if (isset($this->BinaryData[$Key])) {
|
||||
return $this->BinaryData[$Key];
|
||||
}
|
||||
return null;
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -103,11 +103,14 @@ class Pairtwo6 implements ReaderInterface
|
||||
* Returns binary data that was read out the pairtwo file but was not needed immediately
|
||||
*
|
||||
* @param string $Key
|
||||
* @return bool|DateTime|int|string
|
||||
* @return bool|DateTime|int|string|null
|
||||
*/
|
||||
public function getBinaryData(string $Key)
|
||||
{
|
||||
return $this->BinaryData[$Key];
|
||||
if (isset($this->BinaryData[$Key])) {
|
||||
return $this->BinaryData[$Key];
|
||||
}
|
||||
return null;
|
||||
}
|
||||
|
||||
|
||||
@ -138,7 +141,7 @@ class Pairtwo6 implements ReaderInterface
|
||||
fclose($swshandle);
|
||||
|
||||
$offset = 0;
|
||||
|
||||
|
||||
|
||||
$length = 4;
|
||||
$this->setRelease($this->readData('String', substr($swscontents, $offset, $length)));
|
||||
|
Loading…
Reference in New Issue
Block a user