JeroenED
/
libpairtwo
mirror of https://github.com/JeroenED/libpairtwo.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Set correct return types

This commit is contained in:
Jeroen De Meerleer 2019-05-30 21:33:27 +02:00
parent d57a2d053a
commit 4f5f370c12
Signed by: JeroenED
GPG Key ID: 28CCCB8F62BFADD6
2 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Player.php
View File

@ -112,8 +112,7 @@ class Player extends PlayerModel
} }
/** /**
* @param Player $player * @return float
* @return float|null
*/ */
public function getPoints(): float public function getPoints(): float
{ {
@ -130,9 +129,9 @@ class Player extends PlayerModel
/** /**
* @return float * @return int
*/ */
public function getPerformance() public function getPerformance(): int
{ {
$total = 0; $total = 0;
$opponents = 0; $opponents = 0;

27
src/Tiebreaks.php
View File

@ -128,7 +128,7 @@ abstract class Tiebreaks extends Tournament
* @param int $cut * @param int $cut
* @return float * @return float
*/ */
protected function calculateAverageRating(Player $player, int $cut = 0) protected function calculateAverageRating(Player $player, int $cut = 0): ?float
{ {
$pairings = $player->getPairings(); $pairings = $player->getPairings();
$totalrating = 0; $totalrating = 0;
@ -151,9 +151,9 @@ abstract class Tiebreaks extends Tournament
/** /**
* @param Player $player * @param Player $player
* @param int $cut * @param int $cut
* @return float * @return float|null
*/ */
protected function calculateAveragePerformance(Player $player, int $cut = 0) protected function calculateAveragePerformance(Player $player, int $cut = 0): ?float
{ {
$pairings = $player->getPairings(); $pairings = $player->getPairings();
$allratings = []; $allratings = [];
@ -170,12 +170,13 @@ abstract class Tiebreaks extends Tournament
return round(array_sum($allratings) / count($allratings)); return round(array_sum($allratings) / count($allratings));
} }
/** /**
* @param Player $player * @param Player $player
* @param int $cut * @param int $cut
* @return int * @return float|null
*/ */
protected function calculateKoya(Player $player, int $cut = 50) protected function calculateKoya(Player $player, int $cut = 50): ?float
{ {
$tiebreak = 0; $tiebreak = 0;
foreach ($player->getPairings() as $plkey => $plpairing) { foreach ($player->getPairings() as $plkey => $plpairing) {
@ -191,9 +192,9 @@ abstract class Tiebreaks extends Tournament
* @param Player $player * @param Player $player
* @param int $cutlowest * @param int $cutlowest
* @param int $cuthighest * @param int $cuthighest
* @return int * @return float|null
*/ */
protected function calculateBuchholz(Player $player, int $cutlowest = 0, int $cuthighest = 0) protected function calculateBuchholz(Player $player, int $cutlowest = 0, int $cuthighest = 0): ?float
{ {
$tiebreak = 0; $tiebreak = 0;
$intpairings = $player->getPairings(); $intpairings = $player->getPairings();
@ -217,9 +218,9 @@ abstract class Tiebreaks extends Tournament
/** /**
* @param Player $player * @param Player $player
* @return float|int|null * @return float|null
*/ */
protected function calculateSonneborn(Player $player) protected function calculateSonneborn(Player $player): ?float
{ {
$tiebreak = 0; $tiebreak = 0;
foreach ($player->getPairings() as $key => $pairing) { foreach ($player->getPairings() as $key => $pairing) {
@ -235,9 +236,9 @@ abstract class Tiebreaks extends Tournament
/** /**
* @param Player $player * @param Player $player
* @return int * @return float|null
*/ */
protected function calculateKashdan(Player $player) protected function calculateKashdan(Player $player): ?float
{ {
$tiebreak = 0; $tiebreak = 0;
foreach ($player->getPairings() as $pairing) { foreach ($player->getPairings() as $pairing) {
@ -260,9 +261,9 @@ abstract class Tiebreaks extends Tournament
/** /**
* @param Player $player * @param Player $player
* @return float|int * @return float|null
*/ */
protected function calculateCumulative(Player $player) protected function calculateCumulative(Player $player): ?float
{ {
$tiebreak = 0; $tiebreak = 0;
foreach ($player->getPairings() as $pairing) { foreach ($player->getPairings() as $pairing) {