Updated response handling and added 404 page

The code changes include an update to the response handling in index.php. Now, it checks if the request URI is '/metrics'. If so, it continues with the previous behavior of executing a script and outputting its result. If not, it loads a new 404 error page using Twig templating engine. A new file '404.twig' has been added under templates directory which serves as a custom 404 error page. It displays the requested URI and provides a link back to '/metrics'.
Refactored script for better readability
2024-06-13 16:03:44 +02:00 · 2024-06-13 15:52:08 +02:00
3 changed files with 125 additions and 105 deletions
--- a/index.php
+++ b/index.php
@ -1,6 +1,17 @@
 <?php
-header('Content-Type: text/plain; version=0.0.4');
-$config = getenv('CONFIG_FILE'); 
-$phpbin = getenv('PHP_BINARY');
-$output = shell_exec('CONFIG_FILE="' . $config . '" ' . $phpbin . ' ' . $_SERVER['DOCUMENT_ROOT'] . 'script.php');
-echo $output;
+
+if($_SERVER["REQUEST_URI"] == '/metrics') {
+    header('Content-Type: text/plain; version=0.0.4');
+    $config = getenv('CONFIG_FILE');
+    $phpbin = getenv('PHP_BINARY');
+    $output = shell_exec('CONFIG_FILE="' . $config . '" ' . $phpbin . ' ' . $_SERVER['DOCUMENT_ROOT'] . 'script.php');
+    echo $output;
+} else {
+    require_once('vendor/autoload.php');
+    http_response_code(404);
+    $loader = new \Twig\Loader\FilesystemLoader('templates');
+    $twig = new \Twig\Environment($loader, [
+        'cache' => 'twig_cache',
+    ]);
+    echo $twig->render('404.twig', ['path' => $_SERVER["REQUEST_URI"]]);
+}
--- a/script.php
+++ b/script.php
@ -14,118 +14,115 @@ if(file_exists($cacheFile)) {
 } else {
    $oldconfig = [];
 }
+foreach ($config as $key => &$metric) {
+    if (!isset($metric['submetrics'])) {
+        $metric['submetrics'] = [$metric];
+    }
+    foreach ($metric['submetrics'] as $subkey => &$submetric) {
+        $pid = pcntl_fork();
+        if ($pid > 0) {
+            $pids[] = $pid;
+        } else {
+            if (isset($submetric['command'])) {
+                $output = null;
+                $retval = null;
+                try {
+                    exec($submetric['command'], $output, $retval);
+                    $output = implode("\n", $output);
+                } catch (Exception $e) {
+                    $output = '';
+                }
+            } elseif (isset($submetric['http'])) {
+                $client = new GuzzleHttp\Client();

-if(php_sapi_name() == 'cli' || $_SERVER["REQUEST_URI"] == '/metrics') {
-    foreach ($config as $key => &$metric) {
-        if (!isset($metric['submetrics'])) {
-            $metric['submetrics'] = [$metric];
-        }
-        foreach ($metric['submetrics'] as $subkey => &$submetric) {
-            $pid = pcntl_fork();
-            if ($pid > 0) {
-                $pids[] = $pid;
-            } else {
-                if (isset($submetric['command'])) {
-                    $output = null;
-                    $retval = null;
-                    try {
-                        exec($submetric['command'], $output, $retval);
-                        $output = implode("\n", $output);
-                    } catch (Exception $e) {
+                $options = [];
+                $output = NULL;
+                if (isset($submetric['http']['proxy'])) {
+                    $options['proxy'] = $submetric['http']['proxy'];
+                }
+                if (isset($submetric['http']['data']) && $submetric['http']['data'] == 'responsetime') {
+                    $options['on_stats'] = function (GuzzleHttp\TransferStats $stats) use (&$output) {
+                        $output = $stats->getTransferTime();
+                    };
+                }
+
+                $hasresponse = NULL;
+                try {
+                    $res = $client->request('GET', $submetric['http']['url'], $options);
+                    $hasresponse = true;
+                } catch (GuzzleHttp\Exception\GuzzleException $e) {
+                    if (method_exists($e, 'getResponse')) {
+                        $res = $e->getResponse();
+                        $hasresponse = true;
+                    } else {
+                        $hasresponse = false;
+                    }
+                }
+
+                if (isset($submetric['http']['data']) && $submetric['http']['data'] == 'responsebody') {
+                    if ($hasresponse) {
+                        $output = $res->getBody()->getContents();
+                    } else {
                        $output = '';
                    }
-                } elseif (isset($submetric['http'])) {
-                    $client = new GuzzleHttp\Client();
-
-                    $options = [];
-                    $output = NULL;
-                    if (isset($submetric['http']['proxy'])) {
-                        $options['proxy'] = $submetric['http']['proxy'];
-                    }
-                    if (isset($submetric['http']['data']) && $submetric['http']['data'] == 'responsetime') {
-                        $options['on_stats'] = function (GuzzleHttp\TransferStats $stats) use (&$output) {
-                            $output = $stats->getTransferTime();
-                        };
-                    }
-
-                    $hasresponse = NULL;
-                    try {
-                        $res = $client->request('GET', $submetric['http']['url'], $options);
-                        $hasresponse = true;
-                    } catch (GuzzleHttp\Exception\GuzzleException $e) {
-                        if (method_exists($e, 'getResponse')) {
-                            $res = $e->getResponse();
-                            $hasresponse = true;
-                        } else {
-                            $hasresponse = false;
-                        }
-                    }
-
-                    if (isset($submetric['http']['data']) && $submetric['http']['data'] == 'responsebody') {
-                        if ($hasresponse) {
-                            $output = $res->getBody()->getContents();
-                        } else {
-                            $output = '';
-                        }
-                    } elseif ((isset($submetric['http']['statuscode'])) && (isset($submetric['http']['data']) && $submetric['http']['data'] == 'hasresponse')) {
-                        if ($hasresponse) {
-                            $output = $output = (int)in_array($res->getStatusCode(), $submetric['http']['statuscode']);;
-                        } else {
-                            $output = 0;
-                        }
-                    } elseif (isset($submetric['http']['data']) && $submetric['http']['data'] == 'hasresponse') {
-                        $output = (int)$hasresponse;
+                } elseif ((isset($submetric['http']['statuscode'])) && (isset($submetric['http']['data']) && $submetric['http']['data'] == 'hasresponse')) {
+                    if ($hasresponse) {
+                        $output = $output = (int)in_array($res->getStatusCode(), $submetric['http']['statuscode']);;
+                    } else {
+                        $output = 0;
                    }
+                } elseif (isset($submetric['http']['data']) && $submetric['http']['data'] == 'hasresponse') {
+                    $output = (int)$hasresponse;
                }
-
-                if (isset($submetric['jsonelem'])) {
-                    $submetric['value'] = getArrayValue($submetric['jsonelem'], json_decode($output, true));
-                } else {
-                    $submetric['value'] = $output;
-                }
-
-                if (is_bool($submetric['value'])) $submetric['value'] = $submetric['value'] ? 1 : 0;
-
-                file_put_contents('/tmp/.metrics.' . $key . '.' . $subkey, $submetric['value']);
-                exit();
            }
-        }
-    }
-    foreach ($pids as $pid) {
-        pcntl_waitpid($pid, $none);
-    }

-
-    foreach ($config as $key => &$metric) {
-        foreach ($metric['submetrics'] as $subkey => &$submetric) {
-            $submetric['value'] = file_get_contents('/tmp/.metrics.' . $key . '.' . $subkey);
-            if (!empty($oldconfig) && !isset($submetric['value']) && (isset($submetric['fallback']) && !empty($submetric['fallback']))) {
-                if (!isset($submetric['fallback']['maxage']) || time() < ($oldconfig[$key]['submetrics'][$subkey]['time'] + $submetric['fallback']['maxage'])) {
-                    if ($submetric['fallback']['type'] == 'previous') {
-                        $submetric['value'] = $oldconfig[$key]['submetrics'][$subkey]['value'];
-                    } elseif ($submetric['fallback']['type'] == 'static') {
-                        $submetric['value'] = $submetric['fallback']['value'];
-                    }
-                    $submetric['time'] = $oldconfig[$key]['submetrics'][$subkey]['time'];
-                } else {
-                    $submetric['value'] = '';
-                    $submetric['time'] = 0;
-                }
+            if (isset($submetric['jsonelem'])) {
+                $submetric['value'] = getArrayValue($submetric['jsonelem'], json_decode($output, true));
            } else {
-                $submetric['time'] = time();
+                $submetric['value'] = $output;
            }
-            unlink('/tmp/.metrics.' . $key . '.' . $subkey);
+
+            if (is_bool($submetric['value'])) $submetric['value'] = $submetric['value'] ? 1 : 0;
+
+            file_put_contents('/tmp/.metrics.' . $key . '.' . $subkey, $submetric['value']);
+            exit();
        }
    }
-
-    file_put_contents($cacheFile, json_encode($config, JSON_PRETTY_PRINT));
-
-    $loader = new \Twig\Loader\FilesystemLoader('templates');
-    $twig = new \Twig\Environment($loader, [
-        'cache' => 'twig_cache',
-    ]);
-    echo $twig->render('metrics.twig', ['config' => $config]);
 }
+foreach ($pids as $pid) {
+    pcntl_waitpid($pid, $none);
+}
+
+
+foreach ($config as $key => &$metric) {
+    foreach ($metric['submetrics'] as $subkey => &$submetric) {
+        $submetric['value'] = file_get_contents('/tmp/.metrics.' . $key . '.' . $subkey);
+        if (!empty($oldconfig) && !isset($submetric['value']) && (isset($submetric['fallback']) && !empty($submetric['fallback']))) {
+            if (!isset($submetric['fallback']['maxage']) || time() < ($oldconfig[$key]['submetrics'][$subkey]['time'] + $submetric['fallback']['maxage'])) {
+                if ($submetric['fallback']['type'] == 'previous') {
+                    $submetric['value'] = $oldconfig[$key]['submetrics'][$subkey]['value'];
+                } elseif ($submetric['fallback']['type'] == 'static') {
+                    $submetric['value'] = $submetric['fallback']['value'];
+                }
+                $submetric['time'] = $oldconfig[$key]['submetrics'][$subkey]['time'];
+            } else {
+                $submetric['value'] = '';
+                $submetric['time'] = 0;
+            }
+        } else {
+            $submetric['time'] = time();
+        }
+        unlink('/tmp/.metrics.' . $key . '.' . $subkey);
+    }
+}
+
+file_put_contents($cacheFile, json_encode($config, JSON_PRETTY_PRINT));
+
+$loader = new \Twig\Loader\FilesystemLoader('templates');
+$twig = new \Twig\Environment($loader, [
+    'cache' => 'twig_cache',
+]);
+echo $twig->render('metrics.twig', ['config' => $config]);

 function getArrayValue($elem, $array) {
    $elem = explode('.', $elem);
--- a/templates/404.twig
+++ b/templates/404.twig
@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html lang="en">
+<meta charset="UTF-8">
+<title>Page Title</title>
+<meta name="viewport" content="width=device-width,initial-scale=1">
+<style>
+</style>
+<body>
+<h1>404 Uri {{ path }} not found</h1>
+<p><a href="/metrics">/metrics</a></p>
+</body>
+</html>